[webkit-reviews] review granted: [Bug 96590] Added 8 bit path to WidthIterator::advance() : [Attachment 163894] Updated Patch with development #if

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 96590: Added 8 bit path to WidthIterator::advance()
https://bugs.webkit.org/show_bug.cgi?id=96590

Attachment 163894: Updated Patch with development #if
https://bugs.webkit.org/attachment.cgi?id=163894&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=163894&action=review


> Source/WebCore/platform/graphics/Latin1TextIterator.h:2
> + * Copyright (C) Research In Motion Limited 2011. All rights reserved.

Why the RIM copyright, and no Apple copyright?

If this is new code, please use the license @
http://www.webkit.org/coding/bsd-license.html.

> Source/WebCore/platform/graphics/Latin1TextIterator.h:30
> +    // The passed in UChar pointer starts at 'currentCharacter'. The
iterator operatoes on the range [currentCharacter, lastCharacter].

Typo: operatoes.

> Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.h:42
> +	   if (character < 0x3041)

This should be a named constant.

> Source/WebCore/platform/graphics/WidthIterator.cpp:257
> +    if (int(m_currentCharacter) >= offset)

No need to cast: m_currentCharacter is an int.