[webkit-reviews] review granted: [Bug 96512] Extend the coverage of the Custom Allocation Framework in WebCore : [Attachment 163864] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 13 09:30:03 PDT 2012
Eric Seidel <eric at webkit.org> has granted Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 96512: Extend the coverage of the Custom Allocation Framework in WebCore
https://bugs.webkit.org/show_bug.cgi?id=96512
Attachment 163864: proposed patch
https://bugs.webkit.org/attachment.cgi?id=163864&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163864&action=review
LGTM. This system is so fragile. :(
>> Source/WebCore/Modules/websockets/WebSocketHandshake.h:49
>> + WTF_MAKE_NONCOPYABLE(WebSocketHandshake); WTF_MAKE_FAST_ALLOCATED;
>
> More than one command on the same line [whitespace/newline] [4]
I'm not sure why same line is better. But I also don't think it matters. :)
More information about the webkit-reviews
mailing list