[webkit-reviews] review denied: [Bug 96614] Need to clear exception in JSDictionary::getWithUndefinedOrNullCheck() : [Attachment 163809] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 13 08:39:57 PDT 2012


Kentaro Hara <haraken at chromium.org> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 96614: Need to clear exception in
JSDictionary::getWithUndefinedOrNullCheck()
https://bugs.webkit.org/show_bug.cgi?id=96614

Attachment 163809: Patch
https://bugs.webkit.org/attachment.cgi?id=163809&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163809&action=review


>> Source/WebCore/ChangeLog:16
>> +
> 
> I'm not an expert here. But according to this description, it should be
IDBDatabase's responsibility to clear exception. I see webkit usually clears
exception immediately after calling into JSC, rather than before.

Yong is right. Would you update the patch?


More information about the webkit-reviews mailing list