[webkit-reviews] review granted: [Bug 95072] [WK2] LayerTreeCoordinator should release unused UpdatedAtlases : [Attachment 163872] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 13 08:13:17 PDT 2012


Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 95072: [WK2] LayerTreeCoordinator should release unused UpdatedAtlases
https://bugs.webkit.org/show_bug.cgi?id=95072

Attachment 163872: Patch
https://bugs.webkit.org/attachment.cgi?id=163872&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=163872&action=review


r=me if you make those two changes. Please wait a few hours before committing
in case Kenneth still has concerns.

> Source/WebKit2/ChangeLog:23
> +	   (WebKit::UpdateAtlas::didSwapBuffers):

Please add a note why you removes the buildLayoutIfNeeded() call and why you
think it's alright to do.

> Source/WebKit2/WebProcess/WebPage/UpdateAtlas.h:49
> +	   ASSERT(!m_isUsed);

ASSERT(!isInUse())


More information about the webkit-reviews mailing list