[webkit-reviews] review denied: [Bug 96636] Add feature flag that enables lang attribute for form controls in LayoutTests : [Attachment 163858] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 96636: Add feature flag that enables lang attribute for form controls in
LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=96636

Attachment 163858: Patch
https://bugs.webkit.org/attachment.cgi?id=163858&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163858&action=review


> Source/WebKit/chromium/ChangeLog:13
> +	   * public/WebRuntimeFeatures.h:
> +	   (WebRuntimeFeatures):
> +	   * src/WebRuntimeFeatures.cpp:
> +	   (WebKit::WebRuntimeFeatures::enableLangAttributeForFormControls):
> +	   (WebKit):
> +	  
(WebKit::WebRuntimeFeatures::isLangAttributeAwareFormControlUIEnabled):

These changes are not needed any more.

> Source/WebCore/testing/InternalSettings.cpp:649
> +    UNUSED_PARAM(ec);

So, you don't need to specify rases(DOMException) in the IDL.

> Source/WebCore/testing/InternalSettings.cpp:651
> +}

You need to update InternalSettings::Backup::Backup() and restoreTo().