[webkit-reviews] review granted: [Bug 96499] [EFL] Remove some parameters in browserCreate() : [Attachment 163849] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Seokju Kwon
<seokju.kwon at samsung.com>'s request for review:
Bug 96499: [EFL] Remove some parameters in browserCreate()
https://bugs.webkit.org/show_bug.cgi?id=96499

Attachment 163849: Patch
https://bugs.webkit.org/attachment.cgi?id=163849&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163849&action=review


> Tools/EWebLauncher/main.c:860
> +    User_Arguments *userArgs;
> +    userArgs = (User_Arguments *)malloc(sizeof(User_Arguments));
> +    if (!userArgs)
> +	   return quit(EINA_FALSE, "ERROR: could not create settings\n");
> +    memset(userArgs, 0, sizeof(User_Arguments));

I still dont get why you need to allocate them on the heap. You could just do
static User_Arguments userArgs;