[webkit-reviews] review granted: [Bug 92504] [EFL][Qt][WK2] Implement shared undo controller for EFL and Qt port : [Attachment 163821] fixed changelog typo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 13 02:33:11 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Michal Pakula vel
Rutka <m.pakula at samsung.com>'s request for review:
Bug 92504: [EFL][Qt][WK2] Implement shared undo controller for EFL and Qt port
https://bugs.webkit.org/show_bug.cgi?id=92504

Attachment 163821: fixed changelog typo
https://bugs.webkit.org/attachment.cgi?id=163821&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163821&action=review


> LayoutTests/ChangeLog:10
> +	   After WebKit2 undo implementation is done, whole editing/undo
> +	   category can be unskipped. Also missing expected results
> +	   were added.

You should write it differently

Unskip the editing/undo category now that the tests are passing. Also add
missing
expected results.


More information about the webkit-reviews mailing list