[webkit-reviews] review granted: [Bug 81606] [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1. : [Attachment 163614] patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 81606: [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
https://bugs.webkit.org/show_bug.cgi?id=81606

Attachment 163614: patch
https://bugs.webkit.org/attachment.cgi?id=163614&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=163614&action=review


> LayoutTests/ChangeLog:9
> +	   6 seconds is harsh for some jquery test cases.
> +	   Therefore, adjusted the value same as WK1 does.

This does not describe the change you are making to LayoutTests. This should
read something like "Unskip jQuery tests which will now consistently pass due
to the increased waitUntilDone timeout", or some such.

> Tools/ChangeLog:9
> +	   6 seconds is harsh for some jquery test cases.
> +	   Therefore, adjusted the value same as WK1 does.

I think it's unfortunate that we have single tests that take six seconds, but
since they're imported I guess there's not much we can do.

jQuery is capitalized like so.

The second line should read "Therefore, adjust the value to match
DumpRenderTree".

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:58
> +const double TestRunner::waitToDumpWatchdogTimerInterval = 30;

Fine with me.