[webkit-reviews] review denied: [Bug 96567] [V8] ScriptController::compileAndRunScript() can crash : [Attachment 163715] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 96567: [V8] ScriptController::compileAndRunScript() can crash
https://bugs.webkit.org/show_bug.cgi?id=96567

Attachment 163715: Patch
https://bugs.webkit.org/attachment.cgi?id=163715&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163715&action=review


>> Source/WebCore/bindings/v8/ScriptSourceCode.h:67
>> +	CachedScript* cachedScript() const { return m_cachedScript ?
m_cachedScript.get() : 0; }
> 
> What does it mean for m_cachedScript to be 0?  It is held as a member, not as
a pointer.

Ah, good point... maybe I was confused. More investigation is needed.