[webkit-reviews] review denied: [Bug 96568] Change base64Encode() output type from Vector<char> to Vector<LChar> : [Attachment 163716] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 96568: Change base64Encode() output type from Vector<char> to Vector<LChar>
https://bugs.webkit.org/show_bug.cgi?id=96568

Attachment 163716: Patch
https://bugs.webkit.org/attachment.cgi?id=163716&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163716&action=review


It is a good idea, but unless there is a good reason for it, we should change
all the APIs accordingly.

> Source/WTF/wtf/text/Base64.h:52
> -WTF_EXPORT_PRIVATE void base64Encode(const char*, unsigned, Vector<char>&,
Base64EncodePolicy = Base64DoNotInsertLFs);
> -WTF_EXPORT_PRIVATE void base64Encode(const Vector<char>&, Vector<char>&,
Base64EncodePolicy = Base64DoNotInsertLFs);
> -WTF_EXPORT_PRIVATE void base64Encode(const CString&, Vector<char>&,
Base64EncodePolicy = Base64DoNotInsertLFs);
> +WTF_EXPORT_PRIVATE void base64Encode(const char*, unsigned, Vector<LChar>&,
Base64EncodePolicy = Base64DoNotInsertLFs);
> +WTF_EXPORT_PRIVATE void base64Encode(const Vector<char>&, Vector<LChar>&,
Base64EncodePolicy = Base64DoNotInsertLFs);
> +WTF_EXPORT_PRIVATE void base64Encode(const CString&, Vector<LChar>&,
Base64EncodePolicy = Base64DoNotInsertLFs);
>  WTF_EXPORT_PRIVATE String base64Encode(const char*, unsigned,
Base64EncodePolicy = Base64DoNotInsertLFs);
>  WTF_EXPORT_PRIVATE String base64Encode(const Vector<char>&,
Base64EncodePolicy = Base64DoNotInsertLFs);
>  WTF_EXPORT_PRIVATE String base64Encode(const CString&, Base64EncodePolicy =
Base64DoNotInsertLFs);

Consistency is important, we should probably change all the Vector<char> to
Vector<LChar>.
Including the base64Decode().