[webkit-reviews] review denied: [Bug 96500] [WK2] Improve log channel decision routine on WebKit : [Attachment 163603] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied KwangYong Choi
<ky0.choi at samsung.com>'s request for review:
Bug 96500: [WK2] Improve log channel decision routine on WebKit
https://bugs.webkit.org/show_bug.cgi?id=96500

Attachment 163603: Patch
https://bugs.webkit.org/attachment.cgi?id=163603&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163603&action=review


This

> Source/WebKit2/Platform/mac/Logging.mac.mm:54
> +void platformInitializeLogChannels()
> +{
> +    initializeLogChannel(&LogContextMenu);
> +    initializeLogChannel(&LogIconDatabase);
> +    initializeLogChannel(&LogKeyHandling);
> +    initializeLogChannel(&LogSessionState);
> +    initializeLogChannel(&LogTextInput);
> +    initializeLogChannel(&LogView);

As a result of this patch, each platform is responsible for knowing about all
log channels, not just about how to initialize them. This is not maintainable -
adding a logging channel should not require changing platform specific code.