[webkit-reviews] review denied: [Bug 96548] Unprefix IndexedDB : [Attachment 163678] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied David Grogan <dgrogan at chromium.org>'s
request for review:
Bug 96548: Unprefix IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=96548

Attachment 163678: Patch
https://bugs.webkit.org/attachment.cgi?id=163678&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163678&action=review


> Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.h:45
>      static IDBFactory* webkitIndexedDB(DOMWindow*);
> +    static IDBFactory* indexedDB(DOMWindow*);

You should just delete webkitIndexedDB.  It's not needed.

> Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.idl:45
> +	   readonly attribute IDBFactory indexedDB;

The webkitIndexedDB entrypoint should use
https://trac.webkit.org/wiki/WebKitIDL#ImplementedAs