[webkit-reviews] review denied: [Bug 90968] [NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW : [Attachment 163643] draft patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 12 09:28:08 PDT 2012


Dirk Pranke <dpranke at chromium.org> has denied János Badics
<jbadics at inf.u-szeged.hu>'s request for review:
Bug 90968: [NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW
https://bugs.webkit.org/show_bug.cgi?id=90968

Attachment 163643: draft patch
https://bugs.webkit.org/attachment.cgi?id=163643&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163643&action=review


> Tools/Scripts/webkitpy/layout_tests/port/driver.py:352
> +	   command += "'" + self._port.get_option("time_out_ms")

Perhaps this should only be passed if we know that the driver supports this
argument? What will other ports do if they see this?

Also, self._port.get_option('time_out_ms') will use the global timeout setting,
not the per-test setting, meaning that you won't have two different values for
normal tests and slow tests.


More information about the webkit-reviews mailing list