[webkit-reviews] review denied: [Bug 96528] Respect WEBKITOUTPUTDIR when running EFL tests : [Attachment 163641] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 96528: Respect WEBKITOUTPUTDIR when running EFL tests
https://bugs.webkit.org/show_bug.cgi?id=96528

Attachment 163641: Patch
https://bugs.webkit.org/attachment.cgi?id=163641&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163641&action=review


> Tools/Scripts/webkitpy/layout_tests/port/driver.py:280
> +	   environment['WEBKITOUTPUTDIR'] = os.environ['WEBKITOUTPUTDIR']

I think this probably needs to be guarded by if 'WEBKITOUTPUTDIR' in os.environ
since this may not always be set ...