[webkit-reviews] review requested: [Bug 96374] [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks : [Attachment 163645] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 12 09:03:43 PDT 2012


Christophe Dumez <christophe.dumez at intel.com> has asked  for review:
Bug 96374: [WK2][WKTR] TestRunner needs to implement
dumpApplicationCacheDelegateCallbacks
https://bugs.webkit.org/show_bug.cgi?id=96374

Attachment 163645: Patch
https://bugs.webkit.org/attachment.cgi?id=163645&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Export additional symbols on Windows to fix the following linking issue:
6>   Creating library
C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\lib\InjectedBun
dle.lib and object
C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\lib\InjectedBun
dle.exp
6>InjectedBundlePage.obj : error LNK2019: unresolved external symbol "public:
static class WTF::String __cdecl WTF::String::number(__int64)"
(?number at String@WTF@@SA?AV12 at _J@Z) referenced in function "private: void
__thiscall WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota(struct
OpaqueWKSecurityOrigin const *,__int64)"
(?didReachApplicationCacheOriginQuota at InjectedBundlePage@WTR@@AAEXPBUOpaqueWKSe
curityOrigin@@_J at Z)
6>C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\bin\InjectedB
undle.dll : fatal error LNK1120: 1 unresolved externals


More information about the webkit-reviews mailing list