[webkit-reviews] review denied: [Bug 96445] Introduce SelectorCheckingEffects. : [Attachment 163472] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied  review:
Bug 96445: Introduce SelectorCheckingEffects.
https://bugs.webkit.org/show_bug.cgi?id=96445

Attachment 163472: Patch
https://bugs.webkit.org/attachment.cgi?id=163472&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=163472&action=review


> Source/WebCore/css/SelectorChecker.h:80
> +    // Some information can't be determined until the selector checking
runs.
> +    // This struct captures that information.
> +    struct SelectorCheckingEffects {

Name "Effects" doesn't make sense to me here. Wouldn't it be better to capture
all return values (including SelectorMatch) to something like
SelectorCheckResult?

r- for now.