[webkit-reviews] review granted: [Bug 96496] [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache : [Attachment 163589] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 96496: [WK2][WKTR] TestRunner needs to implement
originsWithApplicationCache
https://bugs.webkit.org/show_bug.cgi?id=96496

Attachment 163589: Patch
https://bugs.webkit.org/attachment.cgi?id=163589&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163589&action=review


> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:333
> +static inline JSValueRef stringArrayToJS(JSContextRef context, WKArrayRef
strings)

I guess this is fine as it only works with strings. Otherwise maybe we should
just be a toJS overload.