[webkit-reviews] review granted: [Bug 96483] Web Inspector: Persistent handle referenced from ScriptWrappable is double counted : [Attachment 163558] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 12 02:34:38 PDT 2012


Alexander Pavlov (apavlov) <apavlov at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 96483: Web Inspector: Persistent handle referenced from ScriptWrappable is
double counted
https://bugs.webkit.org/show_bug.cgi?id=96483

Attachment 163558: Patch
https://bugs.webkit.org/attachment.cgi?id=163558&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163558&action=review


> Source/WTF/ChangeLog:10
> +	   used on fields that are pointers to objects which a parts of bigger
memory

"a parts" -> "are parts"?

> Source/WTF/ChangeLog:11
> +	   blocks(field of another object, element in an array, object
allocated in a

Missing whitespace between 's' and '('

> Source/WTF/ChangeLog:12
> +	   memory arena etc.). We don't want to count such objects memory
separately

objects'

> Source/WebCore/ChangeLog:11
> +	   second time. In order to make the clang plugin that validate memory
instrumentation

validate -> validates

> Source/WebCore/ChangeLog:12
> +	   happy we report it here as weak pointer(no-op).

missing whitespace


More information about the webkit-reviews mailing list