[webkit-reviews] review granted: [Bug 96463] [chromium] Evict textures through the texture manager instead of the resource provider : [Attachment 163507] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 12 01:51:41 PDT 2012


James Robinson <jamesr at chromium.org> has granted Christopher Cameron
<ccameron at chromium.org>'s request for review:
Bug 96463: [chromium] Evict textures through the texture manager instead of the
resource provider
https://bugs.webkit.org/show_bug.cgi?id=96463

Attachment 163507: Patch
https://bugs.webkit.org/attachment.cgi?id=163507&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163507&action=review


R=me, just some really minor things

>
Source/WebCore/platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:56

> +    // Each remaining backing is a leaked opengl texture. There sould be
none.

sould->should

>
Source/WebCore/platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:27
7
> +    evictBackingsToReduceMemory(0, false, resourceProvider);

i think these callsites would all be more readable if you used a 2-state enum
for the second parameter instead of a bool. since the callsites are just
literals, i have to go look for the definition of evictBackingsToReduceMemory
to understand what "false" means


More information about the webkit-reviews mailing list