[webkit-reviews] review denied: [Bug 96472] Web Inspector: InspectorBackend.loadFromJSONIfNeeded should take the JSON url as argument : [Attachment 163523] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Vivek Galatage
<vivekgalatage at gmail.com>'s request for review:
Bug 96472: Web Inspector: InspectorBackend.loadFromJSONIfNeeded should take the
JSON url as argument
https://bugs.webkit.org/show_bug.cgi?id=96472

Attachment 163523: Patch
https://bugs.webkit.org/attachment.cgi?id=163523&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163523&action=review


> Source/WebCore/inspector/front-end/inspector.js:409
> +    var jsonUrl = location.href.slice(0, location.href.lastIndexOf("/")) +
"/../Inspector.json";

It will fail on URL like this:
http://localhost/inspector/front-end/inspector.html?ws=localhost:9222/devtools/
page/2_1

Please test this with the instructions described here:
https://groups.google.com/d/msg/google-chrome-developer-tools/L1nemsmtnJI/ndP4c
YkTy-sJ