[webkit-reviews] review granted: [Bug 96458] [chromium] Flip Y and swizzle inside compositeAndReadback implementation : [Attachment 163497] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 23:29:03 PDT 2012


James Robinson <jamesr at chromium.org> has granted Alexandre Elias
<aelias at chromium.org>'s request for review:
Bug 96458: [chromium] Flip Y and swizzle inside compositeAndReadback
implementation
https://bugs.webkit.org/show_bug.cgi?id=96458

Attachment 163497: Patch
https://bugs.webkit.org/attachment.cgi?id=163497&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163497&action=review


DumpRenderTree uses WebViewImpl, so the total # of flips  / swizzles should be
the same for the GL path in DRT.

> Source/WebCore/platform/graphics/chromium/cc/CCRendererGL.cpp:1177
> +    int rowBytes = rect.width() * 4;

size_t would be marginally more consistent with other code that does byte
addressing (overflow isn't a realistic concern here, but consistency is still
nice)


More information about the webkit-reviews mailing list