[webkit-reviews] review requested: [Bug 44650] Support element() CSS image type : [Attachment 163510] Patch v1: Grammar & Parsing

[bugzilla-daemon at webkit.org]

Anish <bhayani at adobe.com> has asked  for review:
Bug 44650: Support element() CSS image type
https://bugs.webkit.org/show_bug.cgi?id=44650

Attachment 163510: Patch v1: Grammar & Parsing
https://bugs.webkit.org/attachment.cgi?id=163510&action=review

------- Additional Comments from Anish <bhayani at adobe.com>
Incorporated the suggestions by Tony Chang and made CSS Element a
CSSPrimitiveValue instead of a CSSValueList. Looking at how CSS Variables
handles its parsing and grammar, it made more sense to make it a
CSSPrimitiveValue instead of a CSS Value (the usage of -webkit-var(foo) is a
CSSPrimitiveValue whereas the setting of it is a CSSValue). Updated tests to
test that #fff is an elementID and not a color and to look out for
CSSPrimitiveValue. ENABLE_CSS_ELEMENT is no longer in Platform.h, it is a
command line feature disabled by default. Please review this patch as whoever
continues it will benefit greatly if not use this.