[webkit-reviews] review granted: [Bug 96450] [Scoped Style] NodeRareData::m_numberOfScopedHTMLStyleChildren could be replaced with a node flag. : [Attachment 163493] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 20:38:05 PDT 2012


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Hajime Morrita
<morrita at google.com>'s request for review:
Bug 96450: [Scoped Style] NodeRareData::m_numberOfScopedHTMLStyleChildren could
be replaced with a node flag.
https://bugs.webkit.org/show_bug.cgi?id=96450

Attachment 163493: Patch
https://bugs.webkit.org/attachment.cgi?id=163493&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163493&action=review


> Source/WebCore/ChangeLog:10
> +	   Instead of tracking the number of certain node, this chagne compute
the number

chagne->change

> Source/WebCore/html/HTMLStyleElement.cpp:128
> +    // Note: We cannot rely on the 'scoped' element still being present when
this method is invoked.

I think he meant 'scoped' _attribute_?


More information about the webkit-reviews mailing list