[webkit-reviews] review requested: [Bug 96459] [V8] OOM in Workers due to external memory retention. : [Attachment 163500] Proposed patch.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has asked  for review:
Bug 96459: [V8] OOM in Workers due to external memory retention.
https://bugs.webkit.org/show_bug.cgi?id=96459

Attachment 163500: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=163500&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Actually, how does the static "workingSetEstimateMB" function in the case of
workers?


http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/We
bCore/bindings/v8/V8GCController.h&exact_package=chromium&q=workingSetEstimateM
B&type=cs&l=84


And how does the supporting code in Chromium work in the case of threading?
When I see caching on a static object like here
(http://code.google.com/searchframe#OAMlx_jo-ck/src/webkit/glue/webkitplatforms
upport_impl.cc&exact_package=chromium&q=memoryUsageMB&type=cs&l=728) it
concerns me.