[webkit-reviews] review granted: [Bug 96308] percentage widths rendered wrong in vertical writing mode with orthogonal parent : [Attachment 163461] Patch

Tue Sep 11 17:02:52 PDT 2012

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 96308: percentage widths rendered wrong in vertical writing mode with
orthogonal parent
https://bugs.webkit.org/show_bug.cgi?id=96308

Attachment 163461: Patch
https://bugs.webkit.org/attachment.cgi?id=163461&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163461&action=review

> Source/WebCore/rendering/RenderBox.cpp:2130
> +    while (!cb->isRenderView() && !cb->isBody() && !cb->isTableCell() &&
!cb->isOutOfFlowPositioned() && cb->style()->logicalHeight().isAuto() &&
isHorizontalWritingMode() == cb->isHorizontalWritingMode()) {

Nit: I would make a bool |hasPerpendicularContainingBlock|.

> Source/WebCore/rendering/RenderBox.cpp:2149
> +	   availableHeight = cb->logicalWidth() -
cb->borderAndPaddingLogicalWidth();

Nit: cb->contentLogicalWidth() which also subtracts the scrollbar.

>
LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks
.html:25
> +<body onload="checkLayout('.container')">
> +

Nit: Can we dump document.compatMode in the output to make sure we're in quirks
mode?