[webkit-reviews] review granted: [Bug 96429] Add 'any' type to V8 bindings as a synonym for DOMObject : [Attachment 163479] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 16:50:01 PDT 2012


Kentaro Hara <haraken at chromium.org> has granted Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 96429: Add 'any' type to V8 bindings as a synonym for DOMObject
https://bugs.webkit.org/show_bug.cgi?id=96429

Attachment 163479: Patch
https://bugs.webkit.org/attachment.cgi?id=163479&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163479&action=review


OK

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:251
> +	   or $type eq "DOMString" or $type eq "DOMObject" or $type eq "any"
or$type eq "Array" or $type eq "DOMTimeStamp") {

Nit: One space please after 'or'.


More information about the webkit-reviews mailing list