[webkit-reviews] review denied: [Bug 94721] [Chromium] Scheduler will never process a commit until it receives a vsync tick. : [Attachment 162963] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 14:55:51 PDT 2012


James Robinson <jamesr at chromium.org> has denied David Reveman
<reveman at chromium.org>'s request for review:
Bug 94721: [Chromium] Scheduler will never process a commit until it receives a
vsync tick.
https://bugs.webkit.org/show_bug.cgi?id=94721

Attachment 162963: Patch
https://bugs.webkit.org/attachment.cgi?id=162963&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162963&action=review


> Source/WebKit/chromium/tests/CCTextureUpdateControllerTest.cpp:579
> +static void runPendingTasks(FakeCCThread* thread,
FakeCCTextureUpdateController* controller)

it's somewhat terrifying that you have to spin the event loop for this unit
test. why? we don't support nesting of WebThread loops for a reason


More information about the webkit-reviews mailing list