[webkit-reviews] review requested: [Bug 93547] [CSS Exclusions] Enable shape-inside for percentage lengths based on logical height : [Attachment 163425] Incorporating feedback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 13:28:48 PDT 2012


Bear Travis <betravis at adobe.com> has asked  for review:
Bug 93547: [CSS Exclusions] Enable shape-inside for percentage lengths based on
logical height
https://bugs.webkit.org/show_bug.cgi?id=93547

Attachment 163425: Incorporating feedback
https://bugs.webkit.org/attachment.cgi?id=163425&action=review

------- Additional Comments from Bear Travis <betravis at adobe.com>
Responding to feedback from Mihnea.
Updating changelog to be more descriptive.
Caching inQuirksMode boolean in RenderBox::percentageLogicalHeightIsResolvable.
Renaming computeLogicalSizeBasedMeasurements ->
updateRegionsAndExclusionsLogicalSize, and removed the logical width/height
parameters.


More information about the webkit-reviews mailing list