[webkit-reviews] review granted: [Bug 96411] Garden-o-matic should ignore a wider variety of warnings in buildbot json : [Attachment 163409] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 11:26:19 PDT 2012


Adam Barth <abarth at webkit.org> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 96411: Garden-o-matic should ignore a wider variety of warnings in buildbot
json
https://bugs.webkit.org/show_bug.cgi?id=96411

Attachment 163409: Patch
https://bugs.webkit.org/attachment.cgi?id=163409&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163409&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/builders.js:60
> +    function isWarning(text) { return text.indexOf('warning') != -1; }
> +    return step.results[0] > 0 && !step.text.some(isWarning);

I would have just used an anonymous function, but this is fine too.


More information about the webkit-reviews mailing list