[webkit-reviews] review granted: [Bug 96143] Text Autosizing: Don't autosize text in constrained height elements. : [Attachment 163253] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 11 11:05:48 PDT 2012
Julien Chaffraix <jchaffraix at webkit.org> has granted John Mellor
<johnme at chromium.org>'s request for review:
Bug 96143: Text Autosizing: Don't autosize text in constrained height elements.
https://bugs.webkit.org/show_bug.cgi?id=96143
Attachment 163253: Patch
https://bugs.webkit.org/attachment.cgi?id=163253&action=review
------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163253&action=review
I would include a test for a constrained positioned element (ideally one for
fixed and one for absolute). I don't need to see the follow-up patch.
> LayoutTests/ChangeLog:32
> + * fast/text-autosizing/fixed-within-overflow-ancestor.html: Added.
As a whole, fixed should be removed from those test cases' names as it has a
meaning of his own per our discussion 'constrained' is a better alternative.
>
LayoutTests/fast/text-autosizing/fixed-and-overflow-auto-ancestor-expected.html
:16
> + <div style="font-size: 2.5rem">
Nit: we could put 40px here instead of using relative font size and removing
the html selector. The upside is that you don't rely on the relative font size
calculation (which may be something we would like to keep). Not repeated for
the other tests.
> LayoutTests/fast/text-autosizing/fixed-within-overflow-ancestor.html:25
> + This text should be not autosized, as autosizing usually causes
text to wrap onto more lines, which might cause it to overflow the parent's
max-height (the grandparent's overflow-y:auto doesn't prevent this).
It would be nice to specify and explicitly mention the expected font-size in
this case too.
More information about the webkit-reviews
mailing list