[webkit-reviews] review granted: [Bug 96407] We should wait longer before killing the PluginProcess : [Attachment 163399] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 10:36:12 PDT 2012


Anders Carlsson <andersca at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 96407: We should wait longer before killing the PluginProcess
https://bugs.webkit.org/show_bug.cgi?id=96407

Attachment 163399: Patch v1
https://bugs.webkit.org/attachment.cgi?id=163399&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=163399&action=review


> Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:51
> +static const double minimumLifetime = 1800;
> +static const double shutdownTimeout = 600;

Please write these as 30 * 60 and 10 * 60 respectively, that makes it easier to
read the timeouts.


More information about the webkit-reviews mailing list