[webkit-reviews] review granted: [Bug 95619] Investigate if storing a Path member in RenderStyle can improve -webkit-clip-path : [Attachment 163337] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 95619: Investigate if storing a Path member in RenderStyle can improve
-webkit-clip-path
https://bugs.webkit.org/show_bug.cgi?id=95619

Attachment 163337: Patch
https://bugs.webkit.org/attachment.cgi?id=163337&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=163337&action=review


> Source/WebCore/rendering/ClipPathOperation.h:104
> +class ReferenceClipPathOperation : public ClipPathOperation {
> +public:

Why not wait until you use this class before adding it?

> Source/WebCore/rendering/ClipPathOperation.h:135
> +    void* m_data;

It's a bit frustrating that we can't reference a real type from here.