[webkit-reviews] review canceled: [Bug 94023] IndexedDB: Use ScriptValue instead of SerializedScriptValue for put/add/update : [Attachment 163236] Patch

[bugzilla-daemon at webkit.org]

Alec Flett <alecflett at chromium.org> has canceled Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 94023: IndexedDB: Use ScriptValue instead of SerializedScriptValue for
put/add/update
https://bugs.webkit.org/show_bug.cgi?id=94023

Attachment 163236: Patch
https://bugs.webkit.org/attachment.cgi?id=163236&action=review

------- Additional Comments from Alec Flett <alecflett at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163236&action=review


>> Source/WebCore/Modules/indexeddb/IDBCursor.cpp:-149
>> -	}
> 
> Why did you remove it?

it's actually covered by the call below to IDBObjectStore::put() - it was
redundant (I missed its redundancy in an earlier refactoring)

>> Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:166
>> +	}
> 
> Shall we make this change in another patch? (before landing this patch)

No this case doesn't really exist in the world before we use ScriptValue.

> Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:168
> +    if (serializedValue->blobURLs().size() > 0) {

(this is the check that was removed from IDBCursor::update - update now calls
into this function)

>> Source/WebCore/bindings/v8/IDBBindingUtilities.cpp:234
>> +	context->Enter();
> 
> Please use v8::Context::Scope rather than calling Enter and Exit manually.

ah! I knew there had to be something like that. Thanks.

thanks for the update guys, new patch coming up soon.