[webkit-reviews] review denied: [Bug 96313] Crash on a long press gesture when touch adjustment is enabled. : [Attachment 163357] Patch

[bugzilla-daemon at webkit.org]

Allan Sandfeld Jensen <allan.jensen at nokia.com> has denied Kevin Ellis
<kevers at chromium.org>'s request for review:
Bug 96313: Crash on a long press gesture when touch adjustment is enabled.
https://bugs.webkit.org/show_bug.cgi?id=96313

Attachment 163357: Patch
https://bugs.webkit.org/attachment.cgi?id=163357&action=review

------- Additional Comments from Allan Sandfeld Jensen <allan.jensen at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=163357&action=review


This could still crash later in appendBasicSubtargetsForNode.

> Source/WebCore/page/TouchAdjustment.cpp:105
> +    ASSERT(node->renderer() || node->isShadowRoot());
> +    if (!node->renderer())
> +	   return false;

The check will need to be in the top of the function. If node does not have a
rendered, the node must always be filtered. 

The existence of the renderer is asserted in appendBasicSubtargetsForNode, and
you need to update the comment for that assertion as well, telling that it is
guaranteed due to the check in the node filter.