[webkit-reviews] review requested: [Bug 90968] [NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW : [Attachment 163359] draft patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 07:35:44 PDT 2012


János Badics <jbadics at inf.u-szeged.hu> has asked  for review:
Bug 90968: [NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW
https://bugs.webkit.org/show_bug.cgi?id=90968

Attachment 163359: draft patch
https://bugs.webkit.org/attachment.cgi?id=163359&action=review

------- Additional Comments from János Badics <jbadics at inf.u-szeged.hu>
I have created a draft patch to resolve the issue on Qt port. There is a stub
in DumpRenderTree.h for other platforms to implement. Now --timeout is passed
to DRT, containing the number given in --time-out-ms or the default value (that
is 5 times the default value if the current test is marked as SLOW in
TestExpectations).

What is your opinion about the draft? Could it be a viable solution if polished
a bit?


More information about the webkit-reviews mailing list