[webkit-reviews] review requested: [Bug 96313] Crash on a long press gesture when touch adjustment is enabled. : [Attachment 163201] Patch

[bugzilla-daemon at webkit.org]

Kevin Ellis <kevers at chromium.org> has asked  for review:
Bug 96313: Crash on a long press gesture when touch adjustment is enabled.
https://bugs.webkit.org/show_bug.cgi?id=96313

Attachment 163201: Patch
https://bugs.webkit.org/attachment.cgi?id=163201&action=review

------- Additional Comments from Kevin Ellis <kevers at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163201&action=review


>> Source/WebCore/page/TouchAdjustment.cpp:104
>> +	    return false;
> 
> So the problem is that node->renderer() can be 0 if it is a shadowRoot?
> Perhaps checking for !node->renderer() would be safer and more informative.
Especially if combined with ASSERT(node->renderer() || node->isShadowRoot())

Yes node->renderer() can be null now that we enable traversal into shadow-DOM
elements during hit testing.  Without the check, the test added for this CL
crashes.