[webkit-reviews] review granted: [Bug 96344] Deploy StringBuilder::appendNumber() and StringBuilder::appendLiteral() in more place : [Attachment 163280] patch

Mon Sep 10 23:45:54 PDT 2012

Benjamin Poulain <benjamin at webkit.org> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 96344: Deploy StringBuilder::appendNumber() and
StringBuilder::appendLiteral() in more place
https://bugs.webkit.org/show_bug.cgi?id=96344

Attachment 163280: patch
https://bugs.webkit.org/attachment.cgi?id=163280&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163280&action=review

> Source/WebCore/ChangeLog:3
> +	   Deploy StringBuilder::appendNumber() and
StringBuilder::appendLiteral() in more place

Typo: place->places

> Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp:62
> +    source.appendLiteral("</style></head><body>\n");
> +    source.appendLiteral("<script>\n");
> +    source.appendLiteral("window.addEventListener('load', function () {");

Hum, this would actually be even better in one append():
    source.appendLiteral("</style></head><body>\n"
			 "<script>\n"
			 "window.addEventListener('load', function () {");

> Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp:98
> +    source.appendLiteral("</script>\n");
> +    source.appendLiteral("</body> </html>\n");

ditto, one literal would be better.

> Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:78
> +    source.appendLiteral("</style></head><body>\n");
> +    source.appendLiteral("<script>\n");
> +    source.appendLiteral("window.addEventListener('load', function () {");

Ditto.

> Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:125
> +    source.appendLiteral("] ");
> +    source.appendLiteral(", 'Cancel'");

Ditto.

> Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:132
> +    source.appendLiteral("</script>\n");
> +    source.appendLiteral("</body> </html>\n");

Ditto.