[webkit-reviews] review denied: [Bug 96197] [EFL][WK2] Provide Implementation for PageClientImpl::processDidCrash() : [Attachment 163243] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 10 22:20:59 PDT 2012


Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 96197: [EFL][WK2] Provide Implementation for
PageClientImpl::processDidCrash()
https://bugs.webkit.org/show_bug.cgi?id=96197

Attachment 163243: patch
https://bugs.webkit.org/attachment.cgi?id=163243&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=163243&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1599
> +    fprintf(stderr, "WARNING: The web process experienced a crash on
'%s'.\n", priv->pageProxy->urlAtProcessExit().utf8().data());

IMO, EINA_LOG_DOM_WARN is better than fprintf for ewk layer.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:59
> + * - "process,crashed", bool*: reports that web process has crashed.

Eina_Bool is correct.


More information about the webkit-reviews mailing list