[webkit-reviews] review granted: [Bug 96311] Remove m_classInfo from JSCell : [Attachment 163258] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 96311: Remove m_classInfo from JSCell
https://bugs.webkit.org/show_bug.cgi?id=96311

Attachment 163258: Patch
https://bugs.webkit.org/attachment.cgi?id=163258&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=163258&action=review


r=me assuming 32_64 changes are in fact legitimate

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:91
> +    const InlineStorageCapacity = 7

Does 32bit gain a full JSValue in a cell?  You've removed one pointer but a
value is 64bits.

> Source/JavaScriptCore/runtime/PropertyOffset.h:39
> -#define INLINE_STORAGE_CAPACITY 6
> +#define INLINE_STORAGE_CAPACITY 7
>  #else
> -#define INLINE_STORAGE_CAPACITY 5
> +#define INLINE_STORAGE_CAPACITY 6

See  my earlier comment