[webkit-reviews] review denied: [Bug 94756] Fix a operator ordering bug in SVGSMILElement::calculateAnimationPercentAndRepeat : [Attachment 162988] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Nico Weber <thakis at chromium.org>'s
request for review:
Bug 94756: Fix a operator ordering bug in
SVGSMILElement::calculateAnimationPercentAndRepeat
https://bugs.webkit.org/show_bug.cgi?id=94756

Attachment 162988: Patch
https://bugs.webkit.org/attachment.cgi?id=162988&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
(In reply to comment #18)
> Let me know if you still disagree, then I'll disable it somewhere further up
the stack.

I just asked you to address the code suggestions from stephen. Adding ifdef's
is not a good solution at all, especially  when you can easily fix it. r-
because of ifdef instead of fixing the problem.

It is ok not to add a test, since it is build system related IMO.