[webkit-reviews] review granted: [Bug 96037] IndexedDB: Optimize key decode and comparison operations : [Attachment 162883] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 10 16:26:21 PDT 2012
Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 96037: IndexedDB: Optimize key decode and comparison operations
https://bugs.webkit.org/show_bug.cgi?id=96037
Attachment 162883: Patch
https://bugs.webkit.org/attachment.cgi?id=162883&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=162883&action=review
>> Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:898
>> ASSERT_NOT_REACHED();
>
> Nor am I going to move this above the return statement. :P
Can you just delete the ASSERT_NOT_REACHED()? It looks like dead code.
More information about the webkit-reviews
mailing list