[webkit-reviews] review granted: [Bug 95346] Get rid of device/host clock synchronization. : [Attachment 163137] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Philippe Liard
<pliard at chromium.org>'s request for review:
Bug 95346: Get rid of device/host clock synchronization.
https://bugs.webkit.org/show_bug.cgi?id=95346

Attachment 163137: Patch
https://bugs.webkit.org/attachment.cgi?id=163137&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163137&action=review


> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:410
> +				    'Please pass --%s.', configuration,
most_recent_binary, most_recent_binary.lower())

As an aside, this warning has always kinda annoyed me since there's no way to
make it go away; if you're trying to run both Release and Debug, one will
always be newer than the other (unless you hack the mtime, of course). I wonder
how much this warning actually helps people.

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:385
> +				    stdout=subprocess.PIPE).stdout)

You can use self._port.host.executive.popen() here and below -	that's slightly
preferred to calling subprocess.Popen() directly.