[webkit-reviews] review requested: [Bug 93547] [CSS Exclusions] Enable shape-inside for percentage lengths based on logical height : [Attachment 163216] Incorporating feedback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 10 14:59:43 PDT 2012


Bear Travis <betravis at adobe.com> has asked  for review:
Bug 93547: [CSS Exclusions] Enable shape-inside for percentage lengths based on
logical height
https://bugs.webkit.org/show_bug.cgi?id=93547

Attachment 163216: Incorporating feedback
https://bugs.webkit.org/attachment.cgi?id=163216&action=review

------- Additional Comments from Bear Travis <betravis at adobe.com>
Fixing up the patch. computeInitialLogicalSizeBasedMeasurements computes the
maximum possible logical height, then passes it, along with the current logical
width, along to regions and exclusions. With the calculations removed,
computeInitialRegionRangeForBlock was obsoleted, and I added a call to
computeRegionRangeForBlock instead.
Removed the term initial
Modified the code to call the new const versions of computeLogicalHeight.
Removed PositionType


More information about the webkit-reviews mailing list