[webkit-reviews] review granted: [Bug 96319] Rename box-sizing applying methods to be more clear about just applying box-sizing. : [Attachment 163210] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 96319: Rename box-sizing applying methods to be more clear about just
applying box-sizing.
https://bugs.webkit.org/show_bug.cgi?id=96319

Attachment 163210: Patch
https://bugs.webkit.org/attachment.cgi?id=163210&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163210&action=review


> Source/WebCore/rendering/AutoTableLayout.cpp:96
> +			       LayoutUnit logicalWidth =
cell->adjustBorderLogicalWidthForBoxSizing(cellLogicalWidth.value());

Nit: I would call it adjustBorderBoxLogicalWidthForBoxSizing to make it clear
that we're not talking about the border width.

> Source/WebCore/rendering/RenderBlock.cpp:5555
> +	   m_minPreferredLogicalWidth = m_maxPreferredLogicalWidth =
adjustContentLogicalWidthForBoxSizing(styleToUse->logicalWidth().value());

Nit: adjustContentBoxLogicalWidthForBoxSizing.