[webkit-reviews] review granted: [Bug 96254] [WTR] Generated source files should include config.h : [Attachment 163119] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 10 14:25:07 PDT 2012
Benjamin Poulain <benjamin at webkit.org> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 96254: [WTR] Generated source files should include config.h
https://bugs.webkit.org/show_bug.cgi?id=96254
Attachment 163119: Patch
https://bugs.webkit.org/attachment.cgi?id=163119&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
> Yes, this obey the order of #include rule 1, `All implementation files must
#include "config.h" first. Header files should never include "config.h"`.
Oh, right! This is unshift, not shift. LGTM.
More information about the webkit-reviews
mailing list