[webkit-reviews] review denied: [Bug 87680] Restore original value of mock scrollbars enabled in InternalSettings : [Attachment 163173] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Marcelo Lira
<marcelo.lira at openbossa.org>'s request for review:
Bug 87680: Restore original value of mock scrollbars enabled in
InternalSettings
https://bugs.webkit.org/show_bug.cgi?id=87680

Attachment 163173: Patch
https://bugs.webkit.org/attachment.cgi?id=163173&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163173&action=review


>>> Tools/DumpRenderTree/chromium/TestShell.cpp:-252
>>> -	     m_prefs.mockScrollbarsEnabled = true;
>> 
>> Why did you remove this line?  It seems that will stop compositing/ tests
from having mock scrollbars.
> 
> The initial state of the mock scroll bars should be set by the tests via
javascript.
> For example, some tests include
LayoutTests/compositing/resources/mock_scrollbars.js
> that sets the mock scroll bars like this:
> 
> window.internals.settings.setMockScrollbarsEnabled(true);

No, that's incorrect.  We want to explicitly override the mock scrollbar
setting for this directory without setting the value in javascript.  If you
want to patch this please preserve this behavior for chromium DRT.