[webkit-reviews] review granted: [Bug 96247] Improve console error messages when 'document.domain' blocks cross-origin script access. : [Attachment 163195] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 10 13:39:26 PDT 2012
Adam Barth <abarth at webkit.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 96247: Improve console error messages when 'document.domain' blocks
cross-origin script access.
https://bugs.webkit.org/show_bug.cgi?id=96247
Attachment 163195: Patch
https://bugs.webkit.org/attachment.cgi?id=163195&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=163195&action=review
Much nicer. Thanks.
> Source/WebCore/page/DOMWindow.cpp:1773
> + SecurityOrigin* requestorOrigin =
activeWindow->document()->securityOrigin();
> + SecurityOrigin* requesteeOrigin = document()->securityOrigin();
We usually call these "active" and "target"
More information about the webkit-reviews
mailing list