[webkit-reviews] review granted: [Bug 74625] Clang doesn't optimize away undefined OwnPtr copy constructor : [Attachment 161011] Also make copy constructor private

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 74625: Clang doesn't optimize away undefined OwnPtr copy constructor
https://bugs.webkit.org/show_bug.cgi?id=74625

Attachment 161011: Also make copy constructor private
https://bugs.webkit.org/attachment.cgi?id=161011&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=161011&action=review


> Source/WTF/wtf/OwnPtr.h:91
> +	   OwnPtr(const OwnPtr<T>&);

I don't think the <T> is needed here.

We should really add a WTF_MARK_DELETED macro in Compiler.h that expands to "=
delete" for compilers that support deleted functions.

> Source/WTF/wtf/OwnPtr.h:93
>	   OwnPtr& operator=(const OwnPtr<T>&);

Same comment here (sorta).