[webkit-reviews] review requested: [Bug 96205] TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations : [Attachment 163178] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <christophe.dumez at intel.com> has asked  for review:
Bug 96205: TestExpectationsChecker._determine_port_from_expectations_path()
does not support cascaded TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=96205

Attachment 163178: Patch
https://bugs.webkit.org/attachment.cgi?id=163178&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Take Tony Chang's feedback into consideration.

Note that I also had to construct the port twice with "webkit_test_runner"
option set to True and False in order to retrieve the TestExpectations paths
for both WebKit1 and WebKit2.

For example, the EFL port returns
["efl-wk1/TestExpectations", "efl/TestExpectations"] for WebKit1
("webkit_test_runner" option is False)
["efl-wk2/TestExpectations", "efl/TestExpectations"] for WebKit2
("webkit_test_runner" option is True)