[webkit-reviews] review requested: [Bug 78493] [CSSRegions][CSSOM] Implement Element.getRegionFlowRanges : [Attachment 163176] Remove the copy-pasted toInt()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 10 12:06:23 PDT 2012


Raul Hudea <rhudea at adobe.com> has asked  for review:
Bug 78493: [CSSRegions][CSSOM] Implement Element.getRegionFlowRanges
https://bugs.webkit.org/show_bug.cgi?id=78493

Attachment 163176: Remove the copy-pasted toInt()
https://bugs.webkit.org/attachment.cgi?id=163176&action=review

------- Additional Comments from Raul Hudea <rhudea at adobe.com>
- As discussed on IRC, the isWritingModeRoot is using the parent style writing
mode, while here is needed the container's one
- For now, I would like to leave the writing mode code as is. If there were a
function like flipForWritingModeForBlock(RenderBlock*, LayoutRect&) the code
would be just:

   container->flipForWritingModeForBlock(currentBlock, rect);
   currentBlock->flipForWritingMode(rect);

  In the worst case, you need to do two flips.


More information about the webkit-reviews mailing list